Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 0.23-scala3 template #309

Merged
merged 11 commits into from
May 11, 2023
Merged

Conversation

channingwalton
Copy link
Contributor

I humbly offer this PR to update the 0.23-scala3 template with the latest libs as asked for in issue #303.

build.sbt Outdated Show resolved Hide resolved
src/main/g8/build.sbt Outdated Show resolved Hide resolved
@armanbilge
Copy link
Member

I think CI is too old to support JDK 17 😕 we need to switch to sbt-typelevel-github-actions.

https://typelevel.org/sbt-typelevel/gha.html

addSbtPlugin("com.codecommit" % "sbt-github-actions" % "0.14.2")

@channingwalton
Copy link
Contributor Author

I think CI is too old to support JDK 17 😕 we need to switch to sbt-typelevel-github-actions.

Ah ok. I will fiddle with it.

@channingwalton
Copy link
Contributor Author

Apologies, I'm still messing with GHA. I think its ok now, will wait for the build.

@channingwalton
Copy link
Contributor Author

Hmm, this is quite painful. I'll see if I can get something working in a test repo.

@rossabaker
Copy link
Member

Actions is in a semi-outage, which might be contributing to your pain.

Some of these upgrades are useful on the main branch. I haven't been maintaining anything for Scala 3, and I think the branches may have diverged too much to use the regular merging strategy, but I may investigate some cherry picks once the dust settles.

@rossabaker
Copy link
Member

Close and reopen so the Actions run.

@rossabaker rossabaker closed this May 11, 2023
@rossabaker rossabaker reopened this May 11, 2023
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, and thank you for persisting, this became a mission-and-a-half 😅

@armanbilge armanbilge merged commit 9e0232f into http4s:0.23-scala3 May 11, 2023
@channingwalton
Copy link
Contributor Author

Woot! Thanks, I learnt things.

froth added a commit that referenced this pull request Jul 24, 2023
@BobenHome
Copy link

Why sbt new http4s/http4s.g8 --branch 0.23-scala3 not success?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants