Skip to content

Commit

Permalink
Bump rubocop to v1.61
Browse files Browse the repository at this point in the history
This is the minimum version that will bundle against our other
dependencies.

I tried going to the latest version (1.65.0) but it added new lints
whose autocorrections break the tests, so this should at least get the
build green again.
  • Loading branch information
tarcieri committed Jul 24, 2024
1 parent d6313d7 commit c9456f4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ group :test do

gem "backports"

gem "rubocop", "~> 1.57.0"
gem "rubocop", "~> 1.61.0"
gem "rubocop-performance", "~> 1.19.1"
gem "rubocop-rake", "~> 0.6.0"
gem "rubocop-rspec", "~> 2.24.1"
Expand Down
2 changes: 1 addition & 1 deletion lib/http/chainable.rb
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def timeout(options)
%i[global read write connect].each do |k|
next unless options.key? k

options["#{k}_timeout".to_sym] = options.delete k
options[:"#{k}_timeout"] = options.delete k
end

branch default_options.merge(
Expand Down
2 changes: 1 addition & 1 deletion lib/http/response/status/reasons.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class Status < ::Delegator
508 => "Loop Detected",
510 => "Not Extended",
511 => "Network Authentication Required"
}.each { |_, v| v.freeze }.freeze
}.each_value(&:freeze).freeze
end
end
end
4 changes: 2 additions & 2 deletions spec/support/proxy_server.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class ProxyServer < WEBrick::HTTPProxyServer
}.freeze

def initialize
super CONFIG
super(CONFIG)
end
end

Expand All @@ -34,6 +34,6 @@ class AuthProxyServer < WEBrick::HTTPProxyServer
CONFIG = ProxyServer::CONFIG.merge ProxyAuthProc: AUTHENTICATOR

def initialize
super CONFIG
super(CONFIG)
end
end

0 comments on commit c9456f4

Please sign in to comment.