Accept output buffer in Response::Body#readpartial #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use a
HTTP::Response::Body
object as a source argument inIO.copy_stream
, allowing easy streaming. It also allows it to be used in the request body for another request (asHTTP::Request::Body::Writer
usesIO.copy_stream
), should anyone want that.Since
IO.copy_stream
uses an output buffer, it makes retrieving the response body much more memory efficient, because we're able to deallocate retrieved chunks. I tested with a 50MB response body, and streaming withHTTP::Response::Body#each
allocated about 52MB of strings, whereas theIO.copy_stream
version allocated only 3MB.IO.copy_stream
requires#readpartial
to haveIO#readpartial
semantics, which among others includes raising andEOFError
when end of file was reached. SinceIO.copy_stream
always uses an output buffer, the exception is raised only when output buffer is specified.