Fix JSON parsing for python requests

[Fr0stM0urne]

Problem
JSON payload for python requests client is not parsed correctly. Specifically, this payload:

{
    "method": "POST",
    "url": "http://mockbin.com/har",
    "httpVersion": "HTTP/1.1",
    "cookies": [],
    "headers": [
        {
            "name": "content-type",
            "value": "application/json"
        }
    ],
    "queryString": [],
    "postData": {
        "mimeType": "application/json",
        "text": "{\"field\":\"value{\\n n1 \"}"
    }
}

will result in this output

import requests

url = "http://mockbin.com/har"

payload = { "field": "value{
 n1 " }
headers = { "content-type": "application/json" }

response = requests.post(url, json=payload, headers=headers)

print(response.text)

Problem is caused by the {\\n and \".

Solution
Used JSON.stringify to convert the jsonObj to string.

Results in correct output:

import requests

url = "http://mockbin.com/har"

payload = {"field":"value{\n n1 "}
headers = { "content-type": "application/json" }

response = requests.post(url, json=payload, headers=headers)

print(response.text)

Indentation can also be added by passing appropriate arguments to JSON.stringify.

[pimterry]

Good catch! This error makes sense, that definitely needs fixing. Would be nice to do so slightly more generally to cover other cases too.

It would also be good to include a test for this, so we don't break it again in future.

[pimterry]

This should work, and it's a good fix.

That said, I think it might be worth fixing this inside literalRepresentation instead, because this bug will apply to anywhere where that's used on an object like your example.

The idea is that this method is supposed to return a Python literal object value for the JS value, very similar to JSON.stringify.

What happens if we just use JSON.stringify for the string case there, on this line?

[pimterry]

Ah, in fact there are a few cases where this current fix won't work, some of which are in the failing tests here. Some notable examples:

• { x: true } becomes { "x": true } but booleans in Python must be capitalized (True)
• { x: null } becomes { "x": null } but null doesn't exist in Python - it has to be None.

literalRepresentation already handles this, so I think just fixing the string case there will solve this.

[Fr0stM0urne]

adding JSON.stringify on this line you mentioned fixes the issue. updated in the commit.

[pimterry]

This looks good to me, merged! 👍

Unfortunately all the tests are broken because Kong/Insomnia have seemingly shutdown the mockbin.com/har endpoint, so every 'request validation' test now fails. What a mess. I've just fixed this on main though (just skipping validation tests, to only check output instead) so hopefully this'll pass correctly on top of that 😄