Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to stop intercepting powershell #125

Merged
merged 2 commits into from
Jul 24, 2024
Merged

ability to stop intercepting powershell #125

merged 2 commits into from
Jul 24, 2024

Conversation

xKiian
Copy link
Contributor

@xKiian xKiian commented Jul 20, 2024

598

pimterry
pimterry reviewed Jul 24, 2024
View reviewed changes
Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation itself looks good, I want to tweak the naming but otherwise this is fantastic 👍

src/interceptors/terminal/terminal-scripts.ts Outdated Show resolved Hide resolved
pimterry
pimterry approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@pimterry pimterry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! 👍

@pimterry pimterry merged commit c986051 into httptoolkit:main Jul 24, 2024
13 checks passed
@pimterry pimterry mentioned this pull request Jul 24, 2024
Open
@xKiian xKiian deleted the powershell-update branch July 25, 2024 18:10
@pimterry pimterry mentioned this pull request Sep 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pimterry pimterry pimterry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xKiian @pimterry