Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from apache:master #38

Closed
wants to merge 5 commits into from
Closed

Conversation

pull[bot]
Copy link

@pull pull bot commented Jul 16, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

This pull request fixes #

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

---

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6529 from avishnus/kubernetes.

Closes #6529

2a82df5 [Cheng Pan] Update dev/dependencyList
a485546 [Cheng Pan] Update pom.xml
1ef0c40 [Cheng Pan] Update dev/dependencyList
4b45b00 [Cheng Pan] Update dev/dependencyList
d0c5174 [Cheng Pan] Update dev/dependencyList
bc2f6b8 [Cheng Pan] Update dev/dependencyList
f76a7f4 [avishnus] Upgrading kubernetes-client

Lead-authored-by: Cheng Pan <[email protected]>
Co-authored-by: avishnus <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
# 🔍 Description
## Issue References 🔗

This pull request fixes #6537

## Describe Your Solution 🔧

Upgrade Flink from 1.19.0 to 1.19.1.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️

#### Behavior With This Pull Request 🎉

#### Related Unit Tests

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6538 from SteNicholas/KYUUBI-6537.

Closes #6537

b39d308 [SteNicholas] [KYUUBI #6537] Upgrade Flink from 1.19.0 to 1.19.1

Authored-by: SteNicholas <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
# 🔍 Description
## Issue References 🔗

This pull request fixes #6534

## Describe Your Solution 🔧

check null ahead.

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Pass GHA

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6540 from pan3793/client-npe.

Closes #6534

6976cd3 [Cheng Pan] [KYUUBI #6534] Fix checkEngineConnectionAlive may throw NPE

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
# 🔍 Description
## Issue References 🔗

This pull request fixes #6523

## Describe Your Solution 🔧

`KyuubiServer` respects configuration properties provided as `--conf` cli options with highest priority.

## Types of changes 🔖

- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

#### Behavior Without This Pull Request ⚰️
REST endpoint starts at `10099` port:
```shell
bin/kyuubi run --conf kyuubi.frontend.rest.bind.port=9999
...
2024-07-10 17:57:24.998 INFO main org.apache.kyuubi.server.KyuubiRestFrontendService: Service[KyuubiRestFrontendService] is started.
2024-07-10 17:57:24.999 INFO main org.apache.kyuubi.server.KyuubiRestFrontendService: Exposing REST endpoint at: http://0.0.0.0:10099
2024-07-10 17:57:24.999 INFO main org.apache.kyuubi.server.KyuubiServer: Service[KyuubiServer] is started.
```

#### Behavior With This Pull Request :tada:
REST endpoint starts at `9999` port:
```shell
bin/kyuubi run --conf kyuubi.frontend.rest.bind.port=9999
...
2024-07-10 17:49:41.659 INFO main org.apache.kyuubi.server.KyuubiRestFrontendService: Service[KyuubiRestFrontendService] is started.
2024-07-10 17:49:41.660 INFO main org.apache.kyuubi.server.KyuubiRestFrontendService: Exposing REST endpoint at: http://0.0.0.0:9999
2024-07-10 17:49:41.660 INFO main org.apache.kyuubi.server.KyuubiServer: Service[KyuubiServer] is started.
```

#### Related Unit Tests
`kyuubi-common/src/test/scala/org/apache/kyuubi/config/KyuubiConfSuite.scala`

---

# Checklist 📝

- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6530 from dnskr/kyuubi-supports-conf-args.

Closes #6523

c7dbb30 [dnskr] Parse command and shift args
4977af1 [dnskr] [KYUUBI #6523] Support configuration with --conf options

Authored-by: dnskr <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
… before picking jobs

# 🔍 Description

This is similar to #5310.

We need to wait for Jetty Server started before picking jobs, otherwise, it may get the wrong local HTTP server port -1.

This only affects Batch V2

## Types of changes 🔖

- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)

## Test Plan 🧪

Tested in internal workloads.

---

# Checklist 📝

- [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)

**Be nice. Be informative.**

Closes #6542 from pan3793/batch-wait-started.

Closes #6542

1f62deb [Cheng Pan] fix
ee1d05d [Cheng Pan] KyuubiBatchService should wait for HTTP server started before picking jobs

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants