[pull] master from apache:master #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
# 🔍 Description ``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` ``` [INFO] --- scala-maven-plugin:4.9.2:doc-jar (attach-scaladocs) kyuubi-server-plugin --- [INFO] compiler plugin: BasicArtifact(com.github.ghik,silencer-plugin_2.12.20,1.7.19,null) error: fatal error: object scala in compiler mirror not found. ``` ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 Successfully run the build command ``` export JAVA_HOME=/path/of/openjdk-17 build/mvn clean install -DskipTests -Dmaven.scaladoc.skip=false ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6820 from pan3793/scaladoc. Closes #6820 f5cee34 [Cheng Pan] Explicitly disable attach-scaladocs for pure Java modules Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
### Why are the changes needed? From my review experience in the past few months, the contributors have less interest in filling the current rich PR template without explicit requests from reviewers. Instead of keeping a rich template to ask the contributors to answer bunches of questions, I prefer to leave only the most important questions to keep the template clean and short. ### How was this patch tested? It's not a code change, it requires manual review. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6821 from pan3793/pr-template. Closes #6821 b1bbdd6 [Cheng Pan] nit ac9a9a5 [Cheng Pan] nit 6fece59 [Cheng Pan] Restore to the plain PULL_REQUEST_TEMPLATE Authored-by: Cheng Pan <[email protected]> Signed-off-by: Kent Yao <[email protected]>
# 🔍 Description ## Issue References 🔗 Fix CVE: GHSA-m6vm-37g8-gqvh ## Describe Your Solution 🔧 Upgrade to 8.4.0, the latest 8.x version. ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests GA. --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6818 from turboFei/mysql_version. Closes #6818 954d3c9 [Wang, Fei] Upgrade mysql jdbc version to 8.4.0 Authored-by: Wang, Fei <[email protected]> Signed-off-by: Kent Yao <[email protected]>
# 🔍 Description ## Issue References 🔗 This pull request fixes #6726 ## Describe Your Solution 🔧 Add trino statement progress ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 #### Behavior Without This Pull Request ⚰️ #### Behavior With This Pull Request 🎉 #### Related Unit Tests --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6759 from taylor12805/trino-progress. Closes #6726 6646c95 [taylor.fan] [KYUUBI #6726] update test case result d84904e [taylor.fan] [KYUUBI #6726] reformat code 2b1c776 [taylor.fan] [KYUUBI #6726] reformat code f635b38 [taylor.fan] [KYUUBI #6726] add test case 7c29ba6 [taylor.fan] [KYUUBI #6726] Support trino stage progress Authored-by: taylor.fan <[email protected]> Signed-off-by: Kent Yao <[email protected]>
# 🔍 Description ## Issue References 🔗 This pull request changes Helm chart configuration approach as discussed in #6123 ## Describe Your Solution 🔧 Suggested implementation makes chart configuration more general and more flexible. It allows to configure Kyuubi (and its engines) by setting configuration file contents to chart properties or by providing configuration files through existing ConfigMaps and Secrets. Also users are not limited by predefined number of files and can put any files to configuration directories. ## Types of changes 🔖 - [ ] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 ### 1. Test suite "Kyuubi configuration" Property file `values-kyuubi-files.yaml` ```yaml kyuubiConf: dir: /opt/kyuubi/conf files: 'kyuubi-env.sh': | #!/usr/bin/env bash export KYUUBI_TEST=true 'kyuubi-custom.properties': | kyuubi.custom=true filesFrom: - configMap: name: kyuubi-configs ``` ConfigMap `kyuubi-configs` from `configmap-kyuubi-configs.yaml` ```yaml apiVersion: v1 kind: ConfigMap metadata: name: kyuubi-configs data: 'kyuubi-test.properties': | kyuubi.config.test=true ``` #### Rendered templates are correct ```shell $ helm template charts/kyuubi -f values-kyuubi-files.yaml -s templates/kyuubi-configmap.yaml -s templates/kyuubi-statefulset.yaml ``` #### Configuration files are in place ```shell $ kubectl create -f configmap-kyuubi-configs.yaml $ helm install kyuubi charts/kyuubi -f values-kyuubi-files.yaml $ kubectl exec kyuubi-0 -- ls conf kyuubi-custom.properties kyuubi-env.sh kyuubi-test.properties ``` ### 2. Test suite "Spark configuration" Property file `values-spark-files.yaml` ```yaml sparkConf: dir: /opt/spark/conf files: 'spark-env.sh': | #!/usr/bin/env bash export SPARK_TEST=true 'spark-custom.properties': | spark.custom=true filesFrom: - configMap: name: spark-configs ``` ConfigMap `spark-configs` from `configmap-spark-configs.yaml` ```yaml apiVersion: v1 kind: ConfigMap metadata: name: spark-configs data: 'spark-test.properties': | spark.config.test=true ``` #### Rendered templates are correct ```shell $ helm template charts/kyuubi -f values-spark-files.yaml -s templates/kyuubi-spark-configmap.yaml -s templates/kyuubi-statefulset.yaml ``` #### Configuration files are in place ```shell $ kubectl create -f configmap-spark-configs.yaml $ helm install kyuubi charts/kyuubi -f values-spark-files.yaml $ kubectl exec kyuubi-0 -- ls ../spark/conf spark-custom.properties spark-env.sh spark-test.properties ``` 3. Test suite "Custom kyuubi-defaults.conf from existing ConfigMap overwrites kyuubi-defaults.conf from values" Property file `values-kyuubi-defaults.yaml` ```yaml kyuubiConf: dir: /opt/kyuubi/conf files: 'kyuubi-defaults.conf': | custom.from.values=true filesFrom: - configMap: name: kyuubi-defaults-config ``` ConfigMap `kyuubi-defaults-config` from `configmap-kyuubi-defaults.yaml` ```yaml apiVersion: v1 kind: ConfigMap metadata: name: kyuubi-defaults-config data: 'kyuubi-defaults.conf': | custom.from.configmap=true ``` #### Rendered templates are correct ```shell $ helm template charts/kyuubi -f values-kyuubi-defaults.yaml -s templates/kyuubi-configmap.yaml -s templates/kyuubi-statefulset.yaml ``` #### Content of `kyuubi-defaults.conf` comes from ConfigMap ```shell $ kubectl create -f configmap-kyuubi-defaults.yaml $ helm install kyuubi charts/kyuubi -f values-kyuubi-defaults.yaml $ kubectl exec kyuubi-0 -- ls conf kyuubi-defaults.conf $ kubectl exec kyuubi-0 -- cat conf/kyuubi-defaults.conf custom.from.configmap=true ``` --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6521 from dnskr/implement-new-helm-chart-configuration-approach. Closes #6521 452dca3 [dnskr] Fix empty value type 14829f3 [dnskr] Revert "[REVERT BEFORE MERGE] Use 'master-snapshot' image tag" 8d90f42 [dnskr] Move default properties from 'kyuubi-defaults.conf' to --conf args 6b3c77f [dnskr] [REVERT BEFORE MERGE] Use 'master-snapshot' image tag fe7c17a [dnskr] [K8S][HELM] Implement new configuration approach Authored-by: dnskr <[email protected]> Signed-off-by: Kent Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )