[pull] master from apache:master #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
### Why are the changes needed? Enable gluten CI for kyuubi apache repo ### How was this patch tested? Review ### Was this patch authored or co-authored using generative AI tooling? No Closes #6846 from wForget/gluten_ci. Closes #6846 22ab3ad [wforget] Enable gluten CI for kyuubi apache repo Authored-by: wforget <[email protected]> Signed-off-by: wforget <[email protected]>
# Description Currently, Kyuubi supports Trino progress in scala-2.12, but got some error in scala-2.13. * Make Trino progress available in scala-2.13 ## Types of changes 🔖 - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Test Plan 🧪 --- # Checklist 📝 - [x] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html) **Be nice. Be informative.** Closes #6841 from naive-zhang/trino-scala13. Closes #6726 0693d28 [Cheng Pan] Update externals/kyuubi-trino-engine/pom.xml c20c49a [native-zhang] modify scala code style 6cfe445 [native-zhang] unify scala grammar c0cd92e [native-zhang] change total stage num back into 3 in TrinoOperationProgressSuite 852398d [naive-zhang] Merge branch 'apache:master' into trino-scala13 6a038ec [native-zhang] move trino progress monitor available in profile scala-2.13 f434a21 [native-zhang] move trino progress monitor into scala-2.12 impl and change state num in some test case 8d291f5 [native-zhang] add scala version diff in pom for trino module Lead-authored-by: native-zhang <[email protected]> Co-authored-by: Cheng Pan <[email protected]> Co-authored-by: naive-zhang <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
### Why are the changes needed?
I am using the podminitor of kyuubi metrics, But I found using the podmonitor's selector.matchLabels can not select correct pods . So I fix it .
I also changed the values.yaml to add an example of podmonitor to improve the usability.
### How was this patch tested?
```
helm install kyuubi .
# kubectl get podmonitor kyuubi -oyaml
apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
annotations:
meta.helm.sh/release-name: kyuubi
meta.helm.sh/release-namespace: default
creationTimestamp: "2024-12-06T07:46:12Z"
generation: 1
labels:
app.kubernetes.io/instance: kyuubi
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: kyuubi
app.kubernetes.io/version: 1.8.0
helm.sh/chart: kyuubi-0.1.0
name: kyuubi
namespace: default
resourceVersion: "7583800"
uid: 0dd11e43-d126-434e-988a-7f1914586e2b
spec:
podMetricsEndpoints:
- path: /metrics
port: prometheus
selector:
matchLabels:
app.kubernetes.io/instance: kyuubi
app.kubernetes.io/name: kyuubi
# kubectl get po -l app.kubernetes.io/instance=kyuubi
NAME READY STATUS RESTARTS AGE
kyuubi-0 1/1 Running 0 24m
kyuubi-1 1/1 Running 0 22m
# kubectl get po -l app.kubernetes.io/name=kyuubi
NAME READY STATUS RESTARTS AGE
kyuubi-0 1/1 Running 0 24m
kyuubi-1 1/1 Running 0 23m
```
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #6840 from zhifanggao/change_podmonitor.
Closes #6840
092f13f [zhifanggao] change the podmonitor to select pods correctly
Authored-by: zhifanggao <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )