[pull] master from apache:master #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
### Why are the changes needed? The original dashboard dashboard template does not work for my use case: In this PR: 1. I add the `baseFilter` variable, default value is `job=~"kyuubi"`. 2. apply the `baseFilter` for all expressions 3. add `baseLegend` for the legendFormat 4. Fix hardcode typos 5. remove the `sum` from the expressions for JVM ### How was this patch tested? <img width="1723" alt="image" src="https://github.com/user-attachments/assets/2da3366d-4cd7-41fe-9a6b-1159d0b61734" /> ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6867 from turboFei/dash_board. Closes #6867 d0d1a36 [Wang, Fei] comments 9fc3b5c [Wang, Fei] use kyuubi_jvm_uptime to get instance 280f97c [Wang, Fei] green f8fc351 [Wang, Fei] all filter 8d1ac2f [Wang, Fei] base legend 9c18bfc [Wang, Fei] save 1a47990 [Wang, Fei] job=kyuubi ea76345 [Wang, Fei] instant datasource and remove cluster 19db2b3 [Wang, Fei] add filter Authored-by: Wang, Fei <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
### Why are the changes needed? Add metrics for SSL keystore expiration, then we can add alert if the keystore will expire in 1 month. ### How was this patch tested? Integration testing. <img width="1721" alt="image" src="https://github.com/user-attachments/assets/f4ef6af6-923b-403c-a80d-06dbb80dbe1c" /> ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6866 from turboFei/keystore_expire. Closes #6866 77c6db0 [Wang, Fei] Add metrics for SSL keystore expiration time #6866 Authored-by: Wang, Fei <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
…ess` to `localhost` for testing ### Why are the changes needed? Similar with `kyuubi.frontend.bind.host`, it is better to set `kyuubi.zookeeper.embedded.client.port.address` to `localhost` for testing as well. ### How was this patch tested? GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6865 from turboFei/zk_bind_host. Closes #6865 9044e28 [Wang, Fei] [TEST] Set kyuubi.zookeeper.embedded.client.port.address for testing Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )