feat: adding configurable ssl configs and change the format of storing kafk… #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! I greatly appreciate your contribution. |
huantt
reviewed
Sep 11, 2023
huantt
reviewed
Sep 12, 2023
huantt
changed the title
|
@shubhamcoc LGTM. |
I will update it another patch @huantt. will it work? |
Why don't you update in this PR? We need to keep README.md up-to-date |
updated the README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding authentication options in Kafka dump tool to create a client with Kafka server having SSL enabled and adding more fields while storing the data in parquet file for exact restore of messages.