Support Add/Remove Labels #8
Conversation
| ) | ||
|
|
||
| const ( | ||
| Assign = "/assign" |
There was a problem hiding this comment.
We have already merged the assign/unassign functionalities in #2.
There was a problem hiding this comment.
Yep. I changed the directory of assign/unassign.
since assign/unassign and labels will handle the same IssueCommentEvent.
There was a problem hiding this comment.
Okay, so do we need the assign directory? As we are putting /unassign in the same file, what about change assign.go to assign_unassign.go and remove the assign directory if nothing else to be added?
There was a problem hiding this comment.
I guess it is better to create different directory for the different action/operation.
So it is convenient to read the codes.
What about assignees as the directory name?
There was a problem hiding this comment.
I am open to that. Can we learn something from kubernetes/test-infra?
There was a problem hiding this comment.
OK, It seems like test-infra is using assign :(
https://github.com/kubernetes/test-infra/blob/master/prow/plugins/assign/assign.go
There was a problem hiding this comment.
Okay, good. I buy it :)
handlers/label/label.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // remove |
There was a problem hiding this comment.
Thanks, I will
| } | ||
|
|
||
| // add | ||
| func add(client *github.Client, event github.IssueCommentEvent) error { |
There was a problem hiding this comment.
Thanks, I will
edisonxiang
force-pushed
the
supportlabel
branch
from
6f2a3d4 to
ae8cbbb
Compare
This PR Fixes: #5
The following comments are supported.
/kind foo
/remove-kind foo
/priority bar
/remove-priority bar