Update Drive Links, Dependencies, and Directory Names #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - I very much enjoyed your paper and look forward to incorporating this benchmark within my own research. While I began to set-up the repository on my local machine, I encountered a few issues (primarily with data acquisition and installation). I made some changes that might be useful as you prepare the "final" release version of this repository.
==
becomes>=
). The current version with strict versioning was unable to be installed on my system due to dependency conflicts. The caveat is that I haven't yet tested the code to determine whether the loosening of version restrictions affects behavior of code in the repo.tdc
dependency in the requirements file. Although you can dofrom tdc import ...
, you actually want to pip installPyTDC
, as there exists a differenttdc
package on pypi.--arg=arg1, arg2,...
becomes--arg arg1 arg2 ...
down
).Feel free to use whatever is useful for the final version. And thank you again for making this resource available!