Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Drive Links, Dependencies, and Directory Names #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kharrigian
Copy link

@kharrigian kharrigian commented Oct 20, 2022

Hi - I very much enjoyed your paper and look forward to incorporating this benchmark within my own research. While I began to set-up the repository on my local machine, I encountered a few issues (primarily with data acquisition and installation). I made some changes that might be useful as you prepare the "final" release version of this repository.

  1. Changed the default "./Data" directory to "./raw-data". On my Mac operating system, filenames are not case sensitive so we encounter a conflict between the "./data" directory which stores utility python code and the "./Data" directory intended to store .pkl files.
  2. Loosened the restrictions on the dependency versions (e.g. == becomes >=). The current version with strict versioning was unable to be installed on my system due to dependency conflicts. The caveat is that I haven't yet tested the code to determine whether the loosening of version restrictions affects behavior of code in the repo.
  3. Fixed the tdc dependency in the requirements file. Although you can do from tdc import ..., you actually want to pip install PyTDC, as there exists a different tdc package on pypi.
  4. I made some updates to the README to clarify which version of Python should be used (which I see is listed in the original paper). I also updated the CLI command for downloading data (the --arg=arg1, arg2,... becomes --arg arg1 arg2 ...
  5. Changed the Google Drive download links (the current versions weren't working, while the new versions were recommended as alternatives by down).

Feel free to use whatever is useful for the final version. And thank you again for making this resource available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant