Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix GHNotificationStream "Unable to parse If-Modified-Since request header" #1984

Merged
merged 3 commits into from
Nov 21, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/kohsuke/github/GHNotificationStream.java
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,9 @@
Thread.sleep(waitTime);
}

req.setHeader("If-Modified-Since", lastModified);
if (lastModified != null) {
req.setHeader("If-Modified-Since", lastModified);

Check warning on line 191 in src/main/java/org/kohsuke/github/GHNotificationStream.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/kohsuke/github/GHNotificationStream.java#L191

Added line #L191 was not covered by tests
}

Requester requester = req.withUrlPath(apiUrl);
GitHubResponse<GHThread[]> response = ((GitHubPageContentsIterable<GHThread>) requester
Expand Down