Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Elastic exporter #233

Draft
wants to merge 13 commits into
base: dev
Choose a base branch
from
Draft

Conversation

papey
Copy link

@papey papey commented Nov 5, 2022

Context

This PR adds Elastic search as a new exporter for Scaphandre. Linked to #92.

src/main.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@uggla
Copy link
Collaborator

uggla commented Nov 7, 2022

A couple of advice, I think you should work with the dev branch. Because there are a lot of changes coming up with this release, it will later ease your rebase. Although I don't know when @bpetit plan to release it.
Take care #234 will bring clap 4. And the way to declare command line arguments will change. So I think you can temporary get the #234 commits for your development and remove them as soon as they will be merged. (assuming they will be merged).

@papey
Copy link
Author

papey commented Nov 7, 2022

A couple of advice, I think you should work with the dev branch. Because there are a lot of changes coming up with this release, it will later ease your rebase. Although I don't know when @bpetit plan to release it. Take care #234 will bring clap 4. And the way to declare command line arguments will change. So I think you can temporary get the #234 commits for your development and remove them as soon as they will be merged. (assuming they will be merged).

Thanks for the early feedback, I will rebase my branch against dev, and set dev as target branch for this PR.

I will also look for clap 4 stuff early since you will probably merge your PR before mine. 👍

@papey papey force-pushed the 92-add-es-exporter branch from 08091c4 to 5eb31ea Compare November 8, 2022 07:52
@papey papey changed the base branch from main to dev November 8, 2022 07:52
@papey
Copy link
Author

papey commented Nov 8, 2022

I will watch for main > dev sync in order to remove the non-related commits.

@papey papey force-pushed the 92-add-es-exporter branch 2 times, most recently from 895360f to 1fb85fb Compare November 10, 2022 08:10
@papey papey force-pushed the 92-add-es-exporter branch from ec80dfe to e2278ef Compare February 11, 2023 17:15
@papey papey force-pushed the 92-add-es-exporter branch from e2278ef to 8953cec Compare March 11, 2023 15:12
@papey papey force-pushed the 92-add-es-exporter branch from b7de5c6 to f6a2da2 Compare March 11, 2023 16:47
@papey
Copy link
Author

papey commented Mar 11, 2023

👋 everyone, hope you are doing well. I finally have time to work on this PR 🤞 !

Here is some basic stuff, with all the internal Scaphandre metrics. I'll probably rename it a bit.

Here is, IMO, the next steps :

  • Rework a bit the naming for scaphandre "self" data
  • Add an index for the sockets part, push the socket data
  • Add an index for the procs part, push the procs data

After that it should be ready for review !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To do
Development

Successfully merging this pull request may close these issues.

2 participants