-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datadog): create exporter module for datadog #86
base: main
Are you sure you want to change the base?
Conversation
53673b0
to
f3dea8f
Compare
Well, at this point, I need async-await to use |
89142ae
to
8e6e2ae
Compare
Hi ! Thanks for the PR ! 🥳 I'm not sure I understand why you need async. I see in the code it's related to waiting the answer from datadog after posting the data. Is this mandatory from datadog to wait for that answer asynchronously ? I mean we use async on prometheus because it is pull mode. Even in that context, I'm not convinced it's the best way to do it as an exporter should not be scrapped by many clients nor very often (not more that every few seconds). So async is kind of a burden for the binary, where it doesn't bring much benefits. For push mode exporters I'd imagine that we could avoid using async, but maybe it's a hard requirement here ? |
8e6e2ae
to
1f842a5
Compare
Signed-off-by: Jérémie Drouet <[email protected]>
22878d6
to
07b0533
Compare
Signed-off-by: Jérémie Drouet <[email protected]>
The library |
Thanks ! I'm working on it to merge with latest changes in main and use the MetricGenerator from @uggla to get metrics. |
Signed-off-by: Jérémie Drouet [email protected]