Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds additional reporting to pubsub for production debugging #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds logging to private Faye
discorick committed Mar 9, 2016
commit 9db35a8bd0c73b5292434ee80560dfccc82bde43
8 changes: 4 additions & 4 deletions config.ru
Original file line number Diff line number Diff line change
@@ -13,6 +13,10 @@ module PrivatePub
end
PrivatePub.set_config secret_token: ENV['SECRET_KEY']

require 'logger'
Faye.logger = Logger.new(STDOUT)
Faye.logger.level = Logger::INFO

require './lib/private_faye'

options = {
@@ -29,7 +33,3 @@ options = {
Faye::WebSocket.load_adapter('thin')
client = Faye::RackAdapter.new(options)
run client

require 'logger'
Faye.logger = Logger.new(STDOUT)
Faye.logger.level = Logger::FATAL
3 changes: 3 additions & 0 deletions lib/private_faye.rb
Original file line number Diff line number Diff line change
@@ -17,8 +17,10 @@ def authenticate_subscribe(message)
subscription = PrivatePub.subscription(:channel => message["subscription"], :timestamp => message["ext"]["private_pub_timestamp"])
if message["ext"]["private_pub_signature"] != subscription[:signature]
message["error"] = "Incorrect signature."
Faye.logger.info message["error"]
elsif PrivatePub.signature_expired? message["ext"]["private_pub_timestamp"].to_i
message["error"] = "Signature has expired."
Faye.logger.info message["error"]
end
end
def authenticate_publish(message)
@@ -31,6 +33,7 @@ def authenticate_publish(message)
raise Error, "No secret_token config set, ensure private_pub.yml is loaded properly."
elsif message["ext"]["private_pub_token"] != PrivatePub.config[:secret_token]
message["error"] = "Incorrect token."
Faye.logger.info message["error"]
else
message["ext"]["private_pub_token"] = nil
end