Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the examples in a plain javascript format #78

Closed
wants to merge 1 commit into from

Conversation

ccoenen
Copy link

@ccoenen ccoenen commented Dec 5, 2016

I converted the coffee script examples.coffee to a plain JavaScript examples-plain.js.

I tried to stay as close as possible to the original, but in the HTTP example, there seems to be a difference that I couldn't account for. I decided to include working code over consistency (and failing code) in that part. All the other examples are pretty much idential to their coffee-script counterparts.

@bkeepers
Copy link
Contributor

bkeepers commented Jun 1, 2017

Thanks @ccoenen. See hubotio/evolution#4 for plans to convert all of Hubot to JavaScript.

@stale stale bot added the stale label Aug 30, 2017
@stale
Copy link

stale bot commented Aug 30, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mose
Copy link
Member

mose commented Sep 2, 2017

Well, now that code is already transformed in js, this PR is not useful anymore.

@mose mose closed this Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants