Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release setup #1361

Merged
merged 8 commits into from
Jun 28, 2017
Merged

semantic-release setup #1361

merged 8 commits into from
Jun 28, 2017

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jun 26, 2017

see

for a release to happen, we have to add another commit which can be done using --allow-empty. hubot@3 comes with a new feature and 3 breaking changes. The commit can look as follows:

feat: `require('hubot/es2015')` exports native ECMAScript 2015 classes

BREAKING CHANGE: [email protected] and [email protected] are no longer supported
BREAKING CHANGE: Deep requires like `require('hubot/src/adapter')` are no longer supported, use `require('hubot').Adapter` instead.
BREAKING CHANGE: `Middleware.ticker()` has been removed. Use `process.nextTick()` instead.

@gr2m gr2m force-pushed the evolution/6/semantic-release branch from c3c062d to 21b2048 Compare June 27, 2017 00:09
@gr2m
Copy link
Contributor Author

gr2m commented Jun 27, 2017

the test with Node 4 fails because npm errors if peerDependencies are not fulfilled while npm 3+ only shows a warning. I suggest we add 0.0.0-development as a valid peerDependency, so the full value would be

  "peerDependencies": {
    "hubot": ">=2 <10 || 0.0.0-development"
  },

I tested it locally and it worked. I’ll update the evolution process and the PRs that I already sent to the scripts

gr2m added a commit to gr2m/hubot-heroku-keepalive that referenced this pull request Jun 27, 2017
gr2m added a commit to gr2m/hubot-google-images that referenced this pull request Jun 27, 2017
gr2m added a commit to gr2m/hubot-google-translate that referenced this pull request Jun 27, 2017
gr2m added a commit to gr2m/hubot-pugme that referenced this pull request Jun 27, 2017
gr2m added a commit to hubotio/hubot-redis-brain that referenced this pull request Jun 27, 2017
gr2m added a commit to gr2m/hubot-shipit that referenced this pull request Jun 27, 2017
Copy link
Member

@technicalpickles technicalpickles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it intentional to remove the CHANGELOG.md? Should we keep that around for things before semantic-release is used?

@gr2m
Copy link
Contributor Author

gr2m commented Jun 28, 2017

@technicalpickles we will add a link to the last version of the CHANGELOG.md file on the 3.0.0 release notes

@gr2m gr2m force-pushed the evolution/6/semantic-release branch from 21b2048 to 6475fc8 Compare June 28, 2017 15:43
gr2m added 2 commits June 28, 2017 08:54
BREAKING CHANGE: [email protected] and [email protected] are no longer supported
BREAKING CHANGE: Deep requires like `require(hubot/src/adapter)` are no longer supported, use `require(hubot).Adapter` instead.
BREAKING CHANGE: `Middleware.ticker()` has been removed. Use `process.nextTick()` instead.
@gr2m
Copy link
Contributor Author

gr2m commented Jun 28, 2017

@technicalpickles alternatively we could create releases for past versions and put the changes in each release note, would you like me to do that?

@gr2m gr2m merged commit 98ad3ce into master Jun 28, 2017
@joeyguerra joeyguerra deleted the evolution/6/semantic-release branch April 22, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants