Middleware execute returns a promise (v2) #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 22, 2017 15:24
Builds in node 0.10.x were failing due to lack of promise support 1339
Allows rejecting if middleware throws related hubotio#1339
|
This has conflicts because changes were made to the 2.19.0 tag, before refactoring coffee to js for v3 release. I don't know if it's possible to make a PR to a tag, rather than a branch, but since the master branch is now dedicated to v3 development, can the hubot team create a branch at the final tag for v2 - for any further submissions to the v2 release in perpetuity? I would then base this PR to that branch. |
timkinnane
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmitting PR #1339 with middleware.execute returning promise allowing async response methods - for v2 hubots, another PR coming for v3