Improve tests #54
Merged
Improve tests #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Grimberg <[email protected]>
Update the Rakefile to be more inline with what is setup when a new module is created via puppet module generate. This Rakefile differs in that it sets default tasks to run wich is all the basic validation, rspec and linting tests Signed-off-by: Andrew Grimberg <[email protected]>
Signed-off-by: Andrew Grimberg <[email protected]>
* User object was depending on a hard coding of the nexus group even though the group information could potentially be something other than 'nexus' * Update the base tests to be a little more correct. The updates / additions is bubbled up the group issue Signed-off-by: Andrew Grimberg <[email protected]>
This should finish off the most basic init class tests. Testing includes validating that if nexus_manage_user is false that the user and group are not created Signed-off-by: Andrew Grimberg <[email protected]>
Fix up the deploy_pro test switch name to accurately state that it is testing deploy_pro Signed-off-by: Andrew Grimberg <[email protected]>
Signed-off-by: Andrew Grimberg <[email protected]>
Signed-off-by: Andrew Grimberg <[email protected]>
Found a couple of resource name spelling mistakes while writing unit tests Signed-off-by: Andrew Grimberg <[email protected]>
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the rspec tests up to 100% coverage. Admittedly there's some dumb tests in here, but at least everything is in a minimal test configuration.
This does not, however, add in validation statements. That really should be done as well.