tech-feat: adapt botonic code to use new flow builder backend endpoints #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanbasten17
force-pushed
the
BLT-1345-botonic-to-use-flow-builder-endpoints-in-hubtype-backend
branch
from
35cea74 to
303daee
Compare
vanbasten17
commented
Jan 29, 2025
Comment on lines
+39
to
+44
| const updatedRequest = newApi.request | ||
| newApi.flowUrl = options.flowUrl.replace( | ||
| '{bot_id}', | ||
| updatedRequest.session.bot.id | ||
| ) | ||
| newApi.flow = options.flow ?? (await newApi.getFlow(options.accessToken)) |
There was a problem hiding this comment.
to make it work correctly in local, we should retrieve botId from userInfo, not from incoming session.bot.user.id, because it will be the default for webchat dev ('00000')
This should be refactored at some point
There was a problem hiding this comment.
this logic could be inside the if of line 36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...