FlowBuilder: Fix isLoading attribute in useWebviewContents #2973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… contents length to set the isLoading attribute returned by the useWebviewContents
vanbasten17
approved these changes
Jan 28, 2025
AlbertGom
approved these changes
Jan 28, 2025
Iru89
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the
isLoadingstate variable in theuseWebviewContentshook and return it as the length of the fetchedcontentsso if the contents object has no keys, it means that the contents are still loading.Context
After the migration from React 16 to React 18 the
useWebviewContentshook was not working as expected because theisLoadingvariable was being set to false before thecontentsvariable was set in the state so the webview was trying to access to an emptycontentsobject.Testing
The pull request has no tests.