Redesign Dimension Change Window #637
Open
+871
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-3007
to
-3020
| int numMetatiles = editor->project->getMapDataSize(widthSpinBox->value(), heightSpinBox->value()); | ||
| int maxMetatiles = editor->project->getMaxMapDataSize(); | ||
| if (numMetatiles <= maxMetatiles) { | ||
| dialog.accept(); | ||
| } else { | ||
| QString errorText = QString("Error: The specified width and height are too large.\n" | ||
| "The maximum layout width and height is the following: (width + 15) * (height + 14) <= %1\n" | ||
| "The specified layout width and height was: (%2 + 15) * (%3 + 14) = %4") | ||
| .arg(maxMetatiles) | ||
| .arg(widthSpinBox->value()) | ||
| .arg(heightSpinBox->value()) | ||
| .arg(numMetatiles); | ||
| errorLabel->setText(errorText); | ||
| errorLabel->setVisible(true); |
There was a problem hiding this comment.
This error check wasn't re-implemented (at least not that I can see)
Comment on lines
+186
to
+188
| void Layout::adjustDimensions(QMargins margins, bool setNewBlockdata, bool enableScriptCallback) { | ||
| int oldWidth = this->width; | ||
| int oldHeight = this->height; |
There was a problem hiding this comment.
Warnings here for enableScriptCallback and oldHeight being unused
| } | ||
| } | ||
|
|
||
| void ResizableRect::hoverLeaveEvent(QGraphicsSceneHoverEvent *event) { |
There was a problem hiding this comment.
Suggested change
| void ResizableRect::hoverLeaveEvent(QGraphicsSceneHoverEvent *event) { | |
| void ResizableRect::hoverLeaveEvent(QGraphicsSceneHoverEvent *) { |
| setFlags(this->flags() | QGraphicsItem::ItemIsMovable | QGraphicsItem::ItemSendsGeometryChanges | QGraphicsItem::ItemIsSelectable); | ||
| } | ||
|
|
||
| void BoundedPixmapItem::paint(QPainter *painter, const QStyleOptionGraphicsItem * item, QWidget *widget) { |
There was a problem hiding this comment.
Suggested change
| void BoundedPixmapItem::paint(QPainter *painter, const QStyleOptionGraphicsItem * item, QWidget *widget) { | |
| void BoundedPixmapItem::paint(QPainter *painter, const QStyleOptionGraphicsItem *, QWidget *) { |
Comment on lines
+144
to
+145
| this->ui->spinBox_width->setLineEditEnabled(false); | ||
| this->ui->spinBox_height->setLineEditEnabled(false); |
There was a problem hiding this comment.
Why are we disabling line editing for these? (and for spinBox_borderWidth/Height)
| int newHeight = this->height + margins.top() + margins.bottom(); | ||
|
|
||
| if (setNewBlockdata) { | ||
| // Fill new blockdata TODO: replace old functions, scripting support, undo etc |
There was a problem hiding this comment.
Aside from scripting is the rest of this still true?
Comment on lines
+2988
to
+2989
|
|
||
| return; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
scriptabilitycloses #616