Skip to content

Commit

Permalink
Move private field comment to a doc comment
Browse files Browse the repository at this point in the history
  • Loading branch information
robhruska committed May 23, 2015
1 parent a0d2394 commit 8ed2243
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions Hudl.Mjolnir/Command/CommandContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,6 @@ public sealed class CommandContext
private readonly ConcurrentDictionary<GroupKey, Lazy<IIsolationThreadPool>> _pools = new ConcurrentDictionary<GroupKey, Lazy<IIsolationThreadPool>>();
private readonly ConcurrentDictionary<GroupKey, Lazy<IIsolationSemaphore>> _fallbackSemaphores = new ConcurrentDictionary<GroupKey, Lazy<IIsolationSemaphore>>();

// These exception types won't count toward breakers tripping or other error counters.
// Useful for things like validation, where the system isn't having any problems and the
// caller needs to validate before invoking. This list is most applicable when using
// [Command] attributes, since extending Command offers the ability to catch these types
// specifically within Execute() - though there may still be some benefit in extended
// Commands for validation-like situations where throwing is still desired.
//
// This is a Dictionary only because there's no great concurrent Set type available. Just
// use the keys if checking for a type.
private readonly ConcurrentDictionary<Type, bool> _ignoredExceptionTypes = new ConcurrentDictionary<Type, bool>();
Expand Down Expand Up @@ -96,6 +89,14 @@ public static IStats Stats
}
}

/// <summary>
/// Ignored exception types won't count toward breakers tripping or other error counters.
/// Useful for things like validation, where the system isn't having any problems and the
/// caller needs to validate before invoking. This list is most applicable when using
/// [Command] attributes, since extending Command offers the ability to catch these types
/// specifically within Execute() - though there may still be some benefit in extended
/// Commands for validation-like situations where throwing is still desired.
/// </summary>
public static void IgnoreExceptions(HashSet<Type> types)
{
if (types == null || types.Count == 0)
Expand Down

0 comments on commit 8ed2243

Please sign in to comment.