Update examples to use max_length instead of deprecated max_seq_length #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all example scripts in the Alignment Handbook to replace the deprecated max_seq_length parameter with max_length, matching the current SFTTrainer API in trl.
Context:
Recent versions of trl have renamed max_seq_length → max_length, causing example scripts to raise errors such as:
Changes:
• Updated all occurrences of max_seq_length → max_length in example scripts.
• No modifications to library or trainer code — only examples were adjusted for compatibility.
Impact:
Examples now run correctly with the latest trl releases, improving out-of-the-box usability.