Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding the actual backend #1309

Merged
merged 15 commits into from
Nov 20, 2023
Merged

Adding the actual backend #1309

merged 15 commits into from
Nov 20, 2023

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Nov 9, 2023

No description provided.

@Narsil Narsil force-pushed the metal2 branch 2 times, most recently from c5703e3 to 9975f2b Compare November 10, 2023 01:18
Base automatically changed from metal1 to main November 10, 2023 07:35
@Narsil Narsil force-pushed the metal2 branch 2 times, most recently from 6d706fd to d840838 Compare November 11, 2023 16:18
@Narsil Narsil mentioned this pull request Nov 11, 2023
Merged
@ivarflakstad ivarflakstad mentioned this pull request Nov 17, 2023
Closed
LaurentMazare
LaurentMazare reviewed Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@LaurentMazare LaurentMazare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a great addition. A couple minor comments attached but hopefully nothing major.
(also just to mention that I haven't reviewed the metal kernels themselves, I definitely trust you more than me on this)

candle-metal-kernels/Cargo.toml Outdated Show resolved Hide resolved
candle-core/src/metal_backend.rs Outdated Show resolved Hide resolved
candle-core/src/metal_backend.rs Show resolved Hide resolved
candle-core/src/metal_backend.rs Outdated Show resolved Hide resolved
candle-core/src/metal_backend.rs Outdated Show resolved Hide resolved
candle-core/src/metal_backend.rs Show resolved Hide resolved
candle-metal-kernels/src/lib.rs Outdated Show resolved Hide resolved
candle-metal-kernels/src/lib.rs Outdated Show resolved Hide resolved
candle-metal-kernels/src/lib.rs Show resolved Hide resolved
candle-metal-kernels/Cargo.toml Outdated Show resolved Hide resolved
Nicolas Patry and others added 2 commits November 20, 2023 14:38
@LaurentMazare
Copy link
Collaborator

Thanks, looks good to me so feel free to merge whenever you're happy with it too.

@Narsil Narsil merged commit b380657 into main Nov 20, 2023
12 checks passed
@Narsil Narsil deleted the metal2 branch November 20, 2023 16:24
@grzuy grzuy mentioned this pull request Nov 20, 2023
Draft
9 tasks
@ivarflakstad ivarflakstad mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzuy grzuy grzuy left review comments

@LaurentMazare LaurentMazare LaurentMazare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Narsil @LaurentMazare @grzuy