Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test disabling transformers containers in docs CI #6757

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Mar 25, 2024

Related to huggingface/doc-builder#487 and internal slack thread. There is now a custom_container option when building docs in CI. When set to "" (instead of "huggingface/transformers-doc-builder" by default), we don't run the CI inside a container, therefore saving ~2min of download time. The plan is to test disabling the transformers container on a few "big" repo and if everything works correctly, we will stop making it the default container. More details on huggingface/doc-builder#487.

cc @mishig25

@Wauplin Wauplin requested a review from lhoestq March 25, 2024 17:16
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lhoestq
Copy link
Member

lhoestq commented Mar 26, 2024

On slack it was mentioned that it was actually slower for datasets, should we close this one or am I missing something ?

@Wauplin Wauplin marked this pull request as draft March 26, 2024 13:33
@Wauplin
Copy link
Contributor Author

Wauplin commented Mar 26, 2024

@lhoestq I converted to draft. Want to make some more tests and will let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants