Add large_list type support in string_to_arrow #6986
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
changed the title
albertvillanova
requested changes
Jun 20, 2024
There was a problem hiding this comment.
Hi @arthasking123, thank for your contribution.
Please note that the functions string_to_arrow and _arrow_to_datasets_dtype are only used for scalar types, which is not the case for LargeListType: this is a container of scalar types.
The support for LargeListType needs a more intricate implementation, involving the Sequence type. See a related unfinished past PR proposal:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add large_list type support in string_to_arrow() and _arrow_to_datasets_dtype() in features.py
Fix #6984