Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pipeline_stable_diffusion_instruct_pix2pix.py to use pytorch_xla and from single safetensor. #10355

Closed
wants to merge 14 commits into from

Conversation

chaowenguo
Copy link
Contributor

@chaowenguo chaowenguo commented Dec 23, 2024

What does this PR do?

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@hlky

Copy link
Collaborator

@hlky hlky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @chaowenguo! I've added instruct-pix2pix to single_file_utils to complete from_single_file support.

Example

from diffusers import StableDiffusionInstructPix2PixPipeline

pipe = StableDiffusionInstructPix2PixPipeline.from_single_file("https://huggingface.co/timbrooks/instruct-pix2pix/blob/main/instruct-pix2pix-00-22000.safetensors")

@hlky
Copy link
Collaborator

hlky commented Dec 23, 2024

cc @yiyixuxu We've had a few PRs for pytorch_xla support recently, should we create an issue to track pipelines missing pytorch_xla support and open it to the community? Edit: Created #10357

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@chaowenguo
Copy link
Contributor Author

@hlky could you actually merge the source?

@hlky hlky requested review from DN6 and a-r-r-o-w December 23, 2024 10:14
@hlky
Copy link
Collaborator

hlky commented Dec 23, 2024

Hi @chaowenguo we'll merge this after the single file changes get another review. Thank you for your patience.

@chaowenguo
Copy link
Contributor Author

I also add support for pytorch_xla and from single safetensors to TextToVideoZeroPipeline. please review it @hlky

@chaowenguo
Copy link
Contributor Author

I also add support for pytorch_xla to rerender_a_video.py. please review it @hlky

@hlky
Copy link
Collaborator

hlky commented Jan 3, 2025

Thanks @chaowenguo, pytorch_xla changes for rerender_a_video look good.

Gentle ping @a-r-r-o-w @sayakpaul to take a look at the instruct-pix2pix from_single_file changes

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes! Could we restrict the changes to InstructPix2Pix for this PR?

@chaowenguo
Copy link
Contributor Author

chaowenguo commented Jan 3, 2025

I also add support for pytorch_xla to rerender_a_video.py. please review it @hlky. but @sayakpaul just want just the change to InstructPix2Pix. but now i am using render a video as a production, i need to install the render a video to 10 different compute node and want the change to be merge in main branch as soon as possible. should i open another pr to deal with render a video first? @hlky

@sayakpaul
Copy link
Member

Requesting you to send over a separate PR for render a video and keeping this PR dedicated to InstructPix2Pix.

@chaowenguo chaowenguo closed this by deleting the head repository Jan 3, 2025
@hlky
Copy link
Collaborator

hlky commented Jan 3, 2025

@sayakpaul The PR was originally just XLA and from_single_file for instruct-pix2pix, I completed from_single_file support myself a797301 which is why I requested further review. The additional XLA changes were added while @chaowenguo has been waiting for review, as we are aiming to complete XLA support and the changes are standard for each pipeline I felt it was ok to add on to this PR.

@sayakpaul
Copy link
Member

Oh okay. I didn't have the full background. In that case, I would like to review once again.

@chaowenguo sorry about the mistake on my part. Could you please reopen the PR? We will review and merge ASAP.

@chaowenguo
Copy link
Contributor Author

chaowenguo commented Jan 3, 2025 via email

@chaowenguo
Copy link
Contributor Author

chaowenguo commented Jan 3, 2025 via email

@sayakpaul
Copy link
Member

Thanks and sincere apologies. @hlky I know this is inconvenient (sorry once again) but could we manually recover the other changes from this PR and make sure to get them in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants