-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pipeline_stable_diffusion_instruct_pix2pix.py to use pytorch_xla and from single safetensor. #10355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @chaowenguo! I've added instruct-pix2pix
to single_file_utils
to complete from_single_file
support.
Example
from diffusers import StableDiffusionInstructPix2PixPipeline
pipe = StableDiffusionInstructPix2PixPipeline.from_single_file("https://huggingface.co/timbrooks/instruct-pix2pix/blob/main/instruct-pix2pix-00-22000.safetensors")
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@hlky could you actually merge the source? |
Hi @chaowenguo we'll merge this after the single file changes get another review. Thank you for your patience. |
I also add support for pytorch_xla and from single safetensors to TextToVideoZeroPipeline. please review it @hlky |
I also add support for pytorch_xla to rerender_a_video.py. please review it @hlky |
Thanks @chaowenguo, Gentle ping @a-r-r-o-w @sayakpaul to take a look at the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your changes! Could we restrict the changes to InstructPix2Pix for this PR?
I also add support for pytorch_xla to rerender_a_video.py. please review it @hlky. but @sayakpaul just want just the change to InstructPix2Pix. but now i am using render a video as a production, i need to install the render a video to 10 different compute node and want the change to be merge in main branch as soon as possible. should i open another pr to deal with render a video first? @hlky |
Requesting you to send over a separate PR for render a video and keeping this PR dedicated to InstructPix2Pix. |
@sayakpaul The PR was originally just XLA and |
Oh okay. I didn't have the full background. In that case, I would like to review once again. @chaowenguo sorry about the mistake on my part. Could you please reopen the PR? We will review and merge ASAP. |
well i already delete the repository. i can not fork the same repository
twice. now i fork t
…On Fri, Jan 3, 2025, 7:36 AM Sayak Paul ***@***.***> wrote:
Oh okay. I didn't have the full background. In that case, I would like to
review once again.
@chaowenguo <https://github.com/chaowenguo> sorry about the mistake on my
part. Could you please reopen the PR? We will review and merge ASAP.
—
Reply to this email directly, view it on GitHub
<#10355 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BNIO5VUWNSUQE5YZZF2Y7BD2I2U6ZAVCNFSM6AAAAABUCUMYVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRZGQYTSMBRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
well i already delete the repository. i can not fork the same repository
twice. now i fork to deal with render a video first. i need it for
production.
…On Fri, Jan 3, 2025, 7:49 AM chaowen guo ***@***.***> wrote:
well i already delete the repository. i can not fork the same repository
twice. now i fork t
On Fri, Jan 3, 2025, 7:36 AM Sayak Paul ***@***.***> wrote:
> Oh okay. I didn't have the full background. In that case, I would like to
> review once again.
>
> @chaowenguo <https://github.com/chaowenguo> sorry about the mistake on
> my part. Could you please reopen the PR? We will review and merge ASAP.
>
> —
> Reply to this email directly, view it on GitHub
> <#10355 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BNIO5VUWNSUQE5YZZF2Y7BD2I2U6ZAVCNFSM6AAAAABUCUMYVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRZGQYTSMBRGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Thanks and sincere apologies. @hlky I know this is inconvenient (sorry once again) but could we manually recover the other changes from this PR and make sure to get them in? |
What does this PR do?
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@hlky