Fix EDMEulerScheduler training with integer timesteps #11991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Training with EDMEulerScheduler was broken due to dtype mismatch when comparing integer timesteps with float scheduler timesteps. This adds proper handling for integer timesteps by mapping them to sigma indices in reverse order to match EDM's descending sigma convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EDMEulerScheduler training with integer timesteps
Fixes #7406
What does this PR do?
EDMEulerScheduler's add_noise method was failing during training because it couldn't handle integer timesteps. The scheduler expected float comparisons but training passes integers, causing an IndexError.
The fix detects integer timesteps and maps them correctly to sigma indices using reverse indexing, since EDM stores sigmas in descending order.
Before submitting
Who can review?
@yiyixuxu @sayakpaul @DN6