cross attn module for ltx #12615
Open
cross attn module for ltx #12615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
sayakpaul
reviewed
Nov 9, 2025
| self.dropout = dropout | ||
| self.out_dim = query_dim | ||
| self.heads = heads | ||
| self.is_cross_attention: Optional[bool] = None |
Member
There was a problem hiding this comment.
I think we can set it to True / False based on the value of cross_attention_dim no?
Contributor
Author
There was a problem hiding this comment.
self.cross_attention_dim is always 4096 for attn1 and attn2 though.
self.cross_attention_dim either gets set to cross_attention_dim or query_dim which are both 4096 in my runs
Member
There was a problem hiding this comment.
if cross_attention_dim is None: self.is_cross_attention = False -- what's up with this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the cross attention module to the LTX Attention Class
Fixes # (issue)
Mirrors the previous Attention class and allows us to distinguish between attention instances