-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement CustomDiffusionAttnProcessor2_0
.
#4604
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
@eliphatfs let me know if this PR is ready for review. |
Hi, how do I do the |
…`. (#1) * Update attnprocessor.md * Update attention_processor.py
I don't find existing tests for CustomDiffusionAttnProcessor, so I will skip adding that for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thank you!
- Could we add this conditional initialization of this class in the training script? Here's an example: https://github.com/huggingface/diffusers/blob/main/examples/dreambooth/train_dreambooth_lora.py#L876C1-L880C1.
@yiyixuxu could you also give this a look?
The CI complains about my code style. How do I spot the problem? |
You can run Guidance: https://github.com/huggingface/diffusers/blob/main/CONTRIBUTING.md |
Sorry I didn't read the guide carefully; I have updated the code formatting, but there are extra errors when I wrong
|
Cc @DN6 could you help here? |
@eliphatfs What version of |
Oh it was |
Done! |
Forgot to update loaders. Now |
@DN6 could you give this a look? |
Bump? |
I see the PRs you mentioned have been merged. Shall we continue working on this thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice this works for me. Thank you so much for implementing this!
Ah, we have some failures on the CI and merge conflicts. Let's make sure to resolve them. |
I have resolved the conflict; looking into the CI failures. |
Sorry but I request a re-run of the tests. It seemed to me that the errors are not relevant to this PR. CI is complaining about a field missing in a huggingface API result. I guess it may be due to API changes and since I have merged the changes in diffusers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me. @sayakpaul @DN6 @yiyixuxu wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for me to merge once the CI is green (except the documentation workflow).
* Implement `CustomDiffusionAttnProcessor2_0` * Doc-strings and type annotations for `CustomDiffusionAttnProcessor2_0`. (huggingface#1) * Update attnprocessor.md * Update attention_processor.py * Interops for `CustomDiffusionAttnProcessor2_0`. * Formatted `attention_processor.py`. * Formatted doc-string in `attention_processor.py` * Conditional CustomDiffusion2_0 for training example. * Remove unnecessary reference impl in comments. * Fix `save_attn_procs`.
* Implement `CustomDiffusionAttnProcessor2_0` * Doc-strings and type annotations for `CustomDiffusionAttnProcessor2_0`. (huggingface#1) * Update attnprocessor.md * Update attention_processor.py * Interops for `CustomDiffusionAttnProcessor2_0`. * Formatted `attention_processor.py`. * Formatted doc-string in `attention_processor.py` * Conditional CustomDiffusion2_0 for training example. * Remove unnecessary reference impl in comments. * Fix `save_attn_procs`.
What does this PR do?
Fixes #4588
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sayakpaul @nupurkmr9