Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX BUG] type of args in train_instruct_pix2pix_sdxl.py #4955

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

Aitical
Copy link
Contributor

@Aitical Aitical commented Sep 9, 2023

What does this PR do?

Fixes type error in default config of args, in example/instruct_pix2pix/train_instruct_pix2pix_sdxl.py

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@putuoka
Copy link

putuoka commented Sep 10, 2023

how about like this?

from enum import Enum

class VaePrecision(Enum):
  FP32 = "fp32"
  FP16 = "fp16" 
  BF16 = "bf16"

# ...

parser.add_argument(
  "--vae_precision",
  type=VaePrecision,
  choices=list(VaePrecision),
  default=VaePrecision.FP32
)

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@patrickvonplaten patrickvonplaten merged commit 9f40d79 into huggingface:main Sep 15, 2023
kashif pushed a commit to kashif/diffusers that referenced this pull request Sep 16, 2023
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants