-
Notifications
You must be signed in to change notification settings - Fork 337
Remove streamlit from Space SDKs #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there a space-changelog file too i think, can you add the deprecation of the streamlit sdk there as well, as a new item?
Thanks! Added. |
Co-authored-by: Pedro Cuenca <[email protected]>
Co-authored-by: Pedro Cuenca <[email protected]>
…d clarify pre-installed dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, can you add a warning on top of spaces-sdks-streamlit to say the default image/SDK is deprecated now, and guide users to use a docker SDK instead?
Co-authored-by: Julien Chaumond <[email protected]>
Thanks for the review. I've updated it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry one last suggestion, but this can be done in a subsequent PR!
Co-authored-by: Julien Chaumond <[email protected]>
Here's a PR to add the screenshot to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks @hysts . will merge it now
This PR updates the documentation to reflect that Streamlit has been moved under Docker section.