fix(mcp): use a more generic folder to put mcp filesystem root #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfuntowicz
force-pushed
the
change-mcp-fs-root
branch
from
d2339cd to
e471fcb
Compare
Wauplin
reviewed
May 1, 2025
julien-c
reviewed
May 1, 2025
|
|
||
| const SERVERS: StdioServerParameters[] = [ | ||
| { | ||
| // Filesystem "official" mcp-server with access to your Desktop | ||
| command: "npx", | ||
| args: ["-y", "@modelcontextprotocol/server-filesystem", join(homedir(), "Desktop")], | ||
| args: ["-y", "@modelcontextprotocol/server-filesystem", MCP_LOCAL_FOLDER], |
There was a problem hiding this comment.
i would rather still use Desktop on mac OS and just homedir() on Win32, can you switch to this?
You can use process.platform === "darwin" to figure out
Thanks!
julien-c
reviewed
May 1, 2025
Comment on lines
+54
to
+57
| if (!existsSync(MCP_LOCAL_FOLDER)) { | ||
| mkdirSync(MCP_LOCAL_FOLDER); | ||
| console.info("created folder", MCP_LOCAL_FOLDER); | ||
| } |
There was a problem hiding this comment.
note (unimportant given we'll not need that code) you're inside an async block so you can use the promise-based variants and just await them
|
i can finish your PR if you want @mfuntowicz? let me know |
|
I've put Happy to take a snab at it 👍🏻 |
|
yes, branching depending on OS is completely fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MCP server attempts to access a folder under
${HOMEDIR}/Desktopwhich is not portable accross different OSes.This PR proposes to change the
Desktoppart to.mcpwhich is OS agnostic and ensure the folder exists when spawning.