fix(hf-inference): image segmentation #1431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oOraph
force-pushed
the
dev/hf-inference-img-seg
branch
3 times, most recently
from
1e88330 to
7768e88
Compare
julien-c
reviewed
May 6, 2025
| response.every((x) => typeof x.label === "string" && typeof x.mask === "string" && typeof x.score === "number") | ||
| response.every( | ||
| (x) => | ||
| typeof x.label === "string" && typeof x.mask === "string" && (!("score" in x) || typeof x.score === "number") |
There was a problem hiding this comment.
Suggested change
| typeof x.label === "string" && typeof x.mask === "string" && (!("score" in x) || typeof x.score === "number") | |
| typeof x.label === "string" && typeof x.mask === "string" && (x.score === undefined || typeof x.score === "number") |
i think you can just do this (more TS-idiomatic)
There was a problem hiding this comment.
Can we just ignore the type checks on score?
There was a problem hiding this comment.
ah my bad I changed it and erased the change by mistake (push force)
-> done: removed the whole type check on score, as we prefer
There was a problem hiding this comment.
hmm it's better to type check no?
There was a problem hiding this comment.
here the type is score?: number; it's a valid type, we don't want random objects or string, just an optional number
oOraph
force-pushed
the
dev/hf-inference-img-seg
branch
4 times, most recently
from
c9a51fb to
e737a5c
Compare
julien-c
reviewed
May 7, 2025
| Array.isArray(response) && | ||
| response.every((x) => typeof x.label === "string" && typeof x.mask === "string" && typeof x.score === "number") | ||
| ) { | ||
| if (Array.isArray(response) && response.every((x) => typeof x.label === "string" && typeof x.mask === "string")) { |
There was a problem hiding this comment.
Suggested change
| if (Array.isArray(response) && response.every((x) => typeof x.label === "string" && typeof x.mask === "string")) { | |
| if (Array.isArray(response) && response.every((x) => typeof x.label === "string" && typeof x.mask === "string" && (x.score === undefined || typeof x.score === "number"))) { |
oOraph
force-pushed
the
dev/hf-inference-img-seg
branch
from
e737a5c to
738bd8e
Compare
related: #1430 Signed-off-by: Raphael Glon <[email protected]>
oOraph
force-pushed
the
dev/hf-inference-img-seg
branch
from
738bd8e to
e972cab
Compare
julien-c
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #1430