Skip to content

Conversation

Deep-unlearning
Copy link
Contributor

Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! PR looks good.

I opened https://huggingface.co/openbmb/VoxCPM-0.5B/discussions/7 as I realized PR https://huggingface.co/openbmb/VoxCPM-0.5B/discussions/4 you've opened is setting the library_name with uppercase and not lowercase. Since the matching is case sensitive, it won't work.

Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Deep-unlearning and good catch re: casing @Wauplin 🤗

@Wauplin
Copy link
Contributor

Wauplin commented Sep 19, 2025

https://huggingface.co/openbmb/VoxCPM-0.5B/discussions/7 has been merged and failing CI is unrelated so let's merge. Expect a few days before getting it live

@Vaibhavs10 Vaibhavs10 merged commit b805f27 into main Sep 19, 2025
3 of 5 checks passed
@Vaibhavs10 Vaibhavs10 deleted the add-voxcpm-snippet branch September 19, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants