Skip to content

Conversation

@pulltheflower
Copy link

Related to issue #3494

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Wauplin
Copy link
Contributor

Wauplin commented Oct 30, 2025

@bot /style

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Style bot fixed some files and pushed the changes.

@pulltheflower
Copy link
Author

@Wauplin I noticed a large number of build and test failures, which seem to be related to network issues. Could this possibly be connected to my changes? I’d appreciate it if you could take a look, thank you!

@Wauplin
Copy link
Contributor

Wauplin commented Oct 31, 2025

I noticed a large number of build and test failures, which seem to be related to network issues.

Yes that was due to temporary issues on our staging infra. It is now resolved.

Note that there are still a few issues due to this PR. See all the

FAILED ../tests/test_hf_api.py::RepoUrlTest::test_repo_url_class - ValueError: not enough values to unpack (expected 2, got 1)
FAILED ../tests/test_hf_api.py::ParseHFUrlTest::test_repo_type_and_id_from_hf_id_on_wrong_values - AssertionError: ValueError not raised
FAILED ../tests/test_hf_api.py::RepoUrlTest::test_repo_url_endpoint - ValueError: not enough values to unpack (expected 2, got 1)
FAILED ../tests/test_hf_api.py::RepoUrlTest::test_repo_url_namespace - ValueError: not enough values to unpack (expected 2, got 1)

looking into the details, this line is now failing.

Could you have a look at it please?

Comment on lines +2763 to +2765
"http://localhost:8080/hf/user/id": [None, "user", "id"],
"http://localhost:8080/hf/datasets/user/id": ["dataset", "user", "id"],
"http://localhost:8080/hf/models/user/id": ["model", "user", "id"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move those at the end given it's an edge case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants