Add support for building CPU-only kernels #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MekkCyber
reviewed
Oct 30, 2025
Comment on lines
+14
to
+20
| foreach(_KERNEL_SRC {{'${' + kernel_name + '_SRC}'}}) | ||
| set_property( | ||
| SOURCE ${_KERNEL_SRC} | ||
| APPEND PROPERTY | ||
| COMPILE_OPTIONS "$<$<COMPILE_LANGUAGE:CXX>:{{ cxx_flags }}>" | ||
| ) | ||
| endforeach() |
There was a problem hiding this comment.
why do we set the flags for each source file separately ?
There was a problem hiding this comment.
IIRC we have to set it on the whole target otherwise, which would result in applying the flags for other kernels as well.
lib/build-sets.nix
Outdated
Comment on lines
133
to
134
| pkgsForCpu = pkgsForMetal; | ||
|
|
There was a problem hiding this comment.
Just to confirm, is this intended ?
Comment on lines
67
to
+69
|
|
||
| metalSupport = buildConfig.metal or false; | ||
|
|
There was a problem hiding this comment.
I think it's better to not default to metalSupport if no backend is available and do that for cpu only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.