Skip to content

Commit

Permalink
Fix warning about precedence of custom tasks over default ones in reg…
Browse files Browse the repository at this point in the history
…istry (#466)

* Fix precedence of default tasks over custom ones in registry

* Revert "Fix precedence of default tasks over custom ones in registry"

This reverts commit 8125ea2.

* Fix comment/warning about precedence of custom over default tasks
  • Loading branch information
albertvillanova authored Dec 20, 2024
1 parent fbca143 commit 264f3f8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/lighteval/tasks/registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,10 @@ def task_registry(self):
intersection = set(default_tasks_registry.keys()).intersection(set(custom_tasks_registry.keys()))
if len(intersection) > 0:
logger.warning(
f"Following tasks ({intersection}) exists both in the default and custom tasks. Will use the default ones on conflict."
f"Following tasks ({intersection}) exists both in the default and custom tasks. Will use the custom ones on conflict."
)

# Defaults tasks should overwrite custom tasks
# Custom tasks overwrite defaults tasks
return {**default_tasks_registry, **custom_tasks_registry}

@property
Expand Down

0 comments on commit 264f3f8

Please sign in to comment.