Adds ability to use functions for prompt definition #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
reviewed
Jul 3, 2024
| @@ -61,6 +61,8 @@ | |||
| if TYPE_CHECKING: | |||
| from lighteval.logging.evaluation_tracker import EvaluationTracker | |||
|
|
|||
| FormatterType = Callable[[dict, str], Doc] | |||
There was a problem hiding this comment.
Why do you include a string?
I don't see which prompt formater takes a string as input
clefourrier
reviewed
Jul 3, 2024
| @@ -149,6 +151,38 @@ def __post_init__(self): | |||
| self.stop_sequence = tuple(self.stop_sequence) if self.stop_sequence is not None else None | |||
|
|
|||
|
|
|||
| def load_prompt_function(prompt_function: str, custom_tasks_module: list | None) -> FormatterType: | |||
There was a problem hiding this comment.
I personally find it less readable with a custom type, we'll see if we keep it through time
|
I've actually updated this PR in #213 to get an homogeneous system, closing this one to avoid merging it accidentally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For python based config, it's way more desirable to use the prompt functions directly instead of passing a string.
MISC:
updates the ruff version in pre-commit to match the pyproject one.