A small improvement in metrics_sample.py::ROUGE
#217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanHB
reviewed
Jul 9, 2024
| @@ -323,6 +323,7 @@ def __init__( | |||
| normalize_gold: callable = None, | |||
| normalize_pred: callable = None, | |||
| aggregation_function: callable = None, | |||
| tokenizer: object = None, | |||
There was a problem hiding this comment.
You could use the tokenizer object here transformers.PreTrainedTokenizer
|
Hi ! Thanks for the PR, could you describe the bug you encoutered and how adding the tokenizer to the rouge function solves it ? |
|
@NathanHB , One might want to use a tokenizer other than the rouge_1 = SampleLevelMetric(
metric="custom_rouge1",
sample_level_fn=ROUGE("rouge1", tokenizer=nltk.tokenize.SpaceTokenizer()).compute,
category=MetricCategory.GENERATIVE,
use_case=MetricUseCase.SUMMARIZATION,
corpus_level_fn=np.mean,
higher_is_better=True,
)
extend_enum(Metrics, "custom_rouge1", rouge_1) |
|
Oh that's great then. Just need to make the tests pass and it should be good to merge :) |
sadra-barikbin
force-pushed
the
small-improvement-in-rouge
branch
from
b73ad9c to
5c7f67d
Compare
NathanHB
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
To fix a tiny bug and do a small improvement to
ROUGEclass.