Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny improvements to endpoint_model.py, base_model.py,... #219

Merged

Conversation

sadra-barikbin
Copy link
Contributor

Hi there!

This PR introduces some small improvements to models.

@sadra-barikbin sadra-barikbin force-pushed the small-improvement-in-models branch from 23543fc to ea7978c Compare July 17, 2024 10:40
@sadra-barikbin sadra-barikbin changed the title Small improvements to endpoint_model.py, base_model.py,... Tiny improvements to endpoint_model.py, base_model.py,... Jul 17, 2024
@NathanHB
Copy link
Member

Hi ! Can you run the pre-commits hook on this ? It looks great we just need to make sure the CI passes.

pip install pre-commit
pre-commit install
pre-commit run --all-files

@clefourrier
Copy link
Member

Hi! Do you want to fix the merge commits or drop the PR?

@HuggingFaceDocBuilderDev
Copy link
Collaborator

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@clefourrier clefourrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clefourrier
Copy link
Member

You'll need to fix conflicts and we'll be good to go :)

@clefourrier clefourrier merged commit 452e031 into huggingface:main Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants