-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom results/details path #451
base: main
Are you sure you want to change the base?
Support custom results/details path #451
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
self, date_id: str | None = None, results_dict: dict | None = None, output_path: str | None = None | ||
): | ||
if output_path: | ||
fs, output_path = url_to_fs(output_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it will be overiding output_dir, this isn't very clear. Users should be able to set the output_path in a coherent way with results and details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. The output_dir
attribute is ignored if the user passes the output_path
parameter.
One could make output_dir
optional:
- If passed, current behavior.
- If None, then needs an output_path for all
save_
methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or simpler: one could use output_dir
as the base dir for the passed output_path
(considered this as relative to output_dir
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also note that the previous approach forces the user to save results and details under a common output_dir
. What about if this is not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made output_dir
optional.
Support custom results/details path.
This PR adds the optional
output_path
parameter toEvaluationTracker.save_results
andEvaluationTracker.save_details
:Also, it makes optional the
EvaluationTracker.output_dir
attribute:TODO: