Made litellm judge backend more robust. #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefourrier
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
LGTM
Side note: We should add an error flag in the ModelResponse if we want to use it to also report these kind of problems - otherwise, if we implement caching, we won't re-run these even though they are incorrect.
Can you also add a failed attribute to the ModelResponse, False by default, and True here?
You'll be able to use it in #480
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
JoelNiklaus
added a commit
to JoelNiklaus/lighteval
that referenced
this pull request
Jan 7, 2025
This reverts commit fdb12f4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric computation fails when a result is None. Therefore retry and otherwise return an error ModelResponse.