Fixes wikitext prompts + some patches on tg models #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, fix small bug in tgi models
NathanHB
reviewed
Feb 27, 2024
NathanHB
approved these changes
Feb 28, 2024
|
I'll need to come back to this to inspect a bit more following some comments in the original issues about disrepancies in score |
NathanHB
reviewed
Feb 28, 2024
| @@ -261,7 +261,10 @@ def _get_docs_from_split(self, splits: list[str], few_shots=False) -> list[Doc]: | |||
| # vs when it's used for the actual prompt. That's why we store whether we are currently using the | |||
| # doc for a fewshot sample (few_shots=True) or not, which then leads to the creation of a different Doc. | |||
| item["__few_shots"] = few_shots | |||
| docs.extend(as_list(self.formatter(item, self.name))) | |||
| cur_docs = self.formatter(item, self.name) | |||
| if cur_docs is None: | |||
There was a problem hiding this comment.
why would it be empty ? Not sure that's expected behaviour
There was a problem hiding this comment.
I did some experiments with the original wikitext, and it contains empty rows, which we want to skip - it should not happen a lot though
clefourrier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches #57
Might need to edit test suite