Update ruff #71
Merged
Update ruff #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanHB
previously approved these changes
Feb 28, 2024
NathanHB
reviewed
Feb 28, 2024
NathanHB
dismissed
their stale review
is the CI working with the new version ?
|
Will update the CI! |
clefourrier
commented
Feb 28, 2024
| @@ -24,7 +24,10 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| python -m pip install ruff==v0.1.2 | |||
| python setup.py egg_info | |||
There was a problem hiding this comment.
This new mechanism
- builds a requirement.txt file from the pytoml
- extracts the mandatory requirements (optional reqs make the file buggy)
- installs ruff using the version in the mandatory requirements, that way we no longer need to update this file when we change the pytoml, it will move on the go :)
There was a problem hiding this comment.
(-c = constraint file in pip)
NathanHB
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this (or a lower bound instead) to allow compatibility between lighteval and the gradio leaderboard template spaces