-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax sentencepiece version #74
Conversation
Don't you mean at most lower bounded? |
Ah for things like Btw if we don't use Happy to amend this PR like that if you agree! |
Thanks for the explanation, makes sense! |
This sounds good ! I see no reason for not doing that :) |
@NathanHB what about using requirement bounds instead of fixed version? :) |
I tend to prefer using fixed versions, as I had issues with breaking changes more than once. However, using bounds for minor version seems better for compatibility with other lib. So Lewis proposition is good for me :) |
Maybe a dumb question, but where is |
If I remember properly, we had to fix the lower bound of the sentencepiece version because it will be needed/used when loading some tokenizers and prior versions had issues with our codebase. |
This PR puts a lower bound on the
sentencepiece
version to be minimally0.1.99
solighteval
can be more easily pip installed in other environments that also havetransformers
installed. If this is OK, I will do something similar with other deps likepytest
which ideally shouldn't be pinned (at most upper bounded)