Add Romanian literals #764
Open
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanHB
reviewed
May 21, 2025
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
thanks for the PR ! only need to run make style and should be good to go :) |
Romanian language does not enumerate with the special characters.
|
Hi @dianaonutu , do you need any help on running the style quality? |
|
Hi @clefourrier, I ran pre-commit locally and no changes were needed. Can you help me with the next steps? |
|
Hm this could happen if maybe your version of the related packages (notably ruff) is a bit behind our current versions, can you make sure your packages are up to date? :) |
|
I have the latest version of ruff. The only problem I have is that vllm was not installed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.