Skip to content

Commit

Permalink
Fix onnx export CLI for transformers >= 4.45 (#2053)
Browse files Browse the repository at this point in the history
* fix onnx export

* add test
  • Loading branch information
echarlaix authored Oct 11, 2024
1 parent 690d35b commit b42db7e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
3 changes: 2 additions & 1 deletion optimum/exporters/onnx/convert.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import numpy as np
import onnx
from transformers.generation import GenerationMixin
from transformers.modeling_utils import get_parameter_dtype
from transformers.utils import is_tf_available, is_torch_available

Expand Down Expand Up @@ -1127,7 +1128,7 @@ def onnx_export_from_model(

if check_if_transformers_greater("4.44.99"):
misplaced_generation_parameters = model.config._get_non_default_generation_parameters()
if model.can_generate() and len(misplaced_generation_parameters) > 0:
if isinstance(model, GenerationMixin) and len(misplaced_generation_parameters) > 0:
logger.warning(
"Moving the following attributes in the config to the generation config: "
f"{misplaced_generation_parameters}. You are seeing this warning because you've set "
Expand Down
8 changes: 8 additions & 0 deletions tests/exporters/onnx/test_exporters_onnx_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,14 @@ def test_diffusion(self):
check=True,
)

def test_sentence_transformers(self):
with TemporaryDirectory() as tmpdirname:
subprocess.run(
f"python3 -m optimum.exporters.onnx --model sentence-transformers-testing/stsb-bert-tiny-onnx --task feature-extraction {tmpdirname}",
shell=True,
check=True,
)

def test_legacy(self):
with TemporaryDirectory() as tmpdirname:
subprocess.run(
Expand Down

0 comments on commit b42db7e

Please sign in to comment.